Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
periodic_system
tutorial is broken #117The last point is the main change: introduced
AUTOBOX
andAUTOCELL
union types, added those to various function type signatures. These unions describe which input types for cell vectors / bounding box and pbcs can be converted into the required format via_auto_cell_vectors
and_auto_pbc
(cf.cell.jl
). E.g. internally the cell vectors are always stured asNTuple{D, SVector{D, T}}
but it can be more convenient to construct them asand
_auto_cell_vectors
will then convert.