Test min, lts and 1 in CI
#478
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 92.11% 94.10% +1.99%
==========================================
Files 14 14
Lines 2903 2935 +32
==========================================
+ Hits 2674 2762 +88
+ Misses 229 173 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| version: 1 | ||
|
|
||
| - os: macOS-13 # Intel | ||
| version: 'min' |
There was a problem hiding this comment.
| version: 'min' | |
| version: 'min' | |
| - os: ubuntu-latest | |
| version: 'nightly' |
Might as well keep one nightly test, IMO
There was a problem hiding this comment.
This was removed in #477 but I'm fine with keeping a test for unreleased Julia versions. Maybe
| version: 'min' | |
| version: 'min' | |
| - os: ubuntu-latest | |
| version: 'pre' |
would give a bit more stable and possibly more relevant test results?
There was a problem hiding this comment.
I'll leave this for a follow-up PR in case we want to test pre or nightly again.
|
I'm fine with it. Please merge. |
#477 changed the CI setup but IMO it's a bit dangerous to stop testing the oldest Julia version that is declared to be supported. It's just too easy to accidentally break compatibility by making use of newer Julia features.
I also increased the MacOS test coverage by testing 1.3 (
min) on the Intel Macs but newer versions such as 1.10 (lts) and 1.11 (1) on the Apple Silicon runners (option 2 in https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019).