Add several updates for bitrot and QA improvements #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for bitrot, add many tests, QA, and CI improvements
Integer
These are always integers anyway
Seems to have a problem with
log(::Complex)
in general. Lookslike a bug, if so. We don't really fix it, but rather skip it.
z == MathConstant.e
The removed function has an underscore prefix and is not called at all by the
API function
lambertw
.This non-API function returns 1::Int, which makes no sense. If you convert
z
toFloat64
,then
1.0::Float64
is returned, which is just as much exactly one as1::Int
.The API function intercepts the input ::MathConstant.e and converts it to float
lambertw was is outdated
Function for branchpoint is better documented.
I don't see that this code path was called by the API in any case.
But curiously, codecov showed that this line was in fact covered by the test suite.
The test suite in fact still passes, as expected, with this line removed.
The removed non-API functions would add nothing if they were called. In any case, they are not.
abs(z::Complex) <= one_t/convert(T, MathConstants.e)
was not tested before.This commit adds a test
I used
finv(lambertw)
, but it was not tested. I tried promoting theidea, but didn't push hard and got no comments. There is now a package
implementing this idea.
In any case, this adds a test for the existing, unexported, function.
I may have argued that the complicated one was slightly more performant.
If it is, it is not significant.
local