Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix method ambiguities #95

Open
kuszmaul opened this issue Aug 28, 2024 · 1 comment
Open

fix method ambiguities #95

kuszmaul opened this issue Aug 28, 2024 · 1 comment

Comments

@kuszmaul
Copy link

julia> using FixedPointDecimals
julia> using Aqua
julia> Aqua.test_all(FixedPointDecimals)
13 ambiguities found. To get a list, set `broken = false`.
Ambiguity #1
(::Type{T})(x::FixedPointDecimals.FixedDecimal) where T<:Union{AbstractFloat, Integer, Rational} @ FixedPointDecimals ~/.julia/packages/FixedPointDecimals/SHo3T/src/FixedPointDecimals.jl:521
Bool(x::Real) @ Base float.jl:171

Possible fix, define
  Bool(::FixedPointDecimals.FixedDecimal)
...
@NHDaly
Copy link
Member

NHDaly commented Aug 28, 2024

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants