Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IO methods of all transforms #85

Closed
juliohm opened this issue May 27, 2022 · 4 comments
Closed

Improve IO methods of all transforms #85

juliohm opened this issue May 27, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@juliohm
Copy link
Member

juliohm commented May 27, 2022

Currently we do not provide Base.show methods for the transforms and their output is quite difficult to digest. We could use some fancy unicode to display the transforms and pipelines to end users.

@juliohm juliohm added the good first issue Good for newcomers label May 27, 2022
@eliascarv
Copy link
Member

eliascarv commented Jun 13, 2022

List of tranforms to inprove I/O:

  • Select
  • Reject
  • Rename
  • StdNames
  • Sort
  • Sample
  • Filter
  • DropMissing
  • Replace
  • Coalesce
  • Coerce
  • Levels
  • OneHot
  • RowTable
  • ColTable
  • Identity
  • Center
  • Scale
  • MinMax
  • Interquartile
  • ZScore
  • Quantile
  • Functional
  • Levels
  • Sort
  • EigenAnalysis
  • PCA
  • DRS
  • SDS
  • Sequential
  • Parallel

@eliascarv eliascarv self-assigned this Jun 13, 2022
@juliohm
Copy link
Member Author

juliohm commented Jun 13, 2022

Perhaps we can leverage the abstract Transform parent type to write a single show method for most transforms. This method could make use of fieldnames, and other Base functions to format and print the fields of the structs. In special cases, we could then write special methods for specific transforms like Sequential and Parallel to use some unicode with arrows.

@juliohm
Copy link
Member Author

juliohm commented Jun 17, 2022

I think we can close this issue now that the fallback is in place? We can open specific issues if necessary to improve specific transforms?

@eliascarv
Copy link
Member

I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants