From ba11544e083afba56bde87cf3cf43baf5f7da466 Mon Sep 17 00:00:00 2001 From: Jakob Nybo Nissen Date: Thu, 18 Feb 2021 18:04:00 +0100 Subject: [PATCH] Fix typo in BitVector constructor --- base/bitarray.jl | 2 +- test/bitarray.jl | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/base/bitarray.jl b/base/bitarray.jl index acc96f7284a54..6175a492cac75 100644 --- a/base/bitarray.jl +++ b/base/bitarray.jl @@ -605,7 +605,7 @@ gen_bitarrayN(::Type{BitVector}, itsz, itr) = gen_bitarra gen_bitarrayN(::Type{BitVector}, itsz::HasShape{1}, itr) = gen_bitarray(itsz, itr) gen_bitarrayN(::Type{BitArray{N}}, itsz::HasShape{N}, itr) where N = gen_bitarray(itsz, itr) # The first of these is just for ambiguity resolution -gen_bitarrayN(::Type{BitVector}, itsz::HasShape{N}, itr) where N = throw(DimensionMismatch("cannot create a $T from a $N-dimensional iterator")) +gen_bitarrayN(::Type{BitVector}, itsz::HasShape{N}, itr) where N = throw(DimensionMismatch("cannot create a BitVector from a $N-dimensional iterator")) gen_bitarrayN(@nospecialize(T::Type), itsz::HasShape{N}, itr) where N = throw(DimensionMismatch("cannot create a $T from a $N-dimensional iterator")) gen_bitarrayN(@nospecialize(T::Type), itsz, itr) = throw(DimensionMismatch("cannot create a $T from a generic iterator")) diff --git a/test/bitarray.jl b/test/bitarray.jl index 23cbeae1ffa5c..f246942452020 100644 --- a/test/bitarray.jl +++ b/test/bitarray.jl @@ -198,6 +198,9 @@ timesofar("utils") ((x+y)%5==2 for x = 1:n1 for y = 1:n2)) @test BitArray(g) == BitArray(collect(g)) end + @test_throws DimensionMismatch BitVector(false) + @test_throws DimensionMismatch BitVector((iszero(i%4) for i in 1:n1, j in 1:n2)) + @test_throws DimensionMismatch BitMatrix((isodd(i) for i in 1:3)) end @testset "constructor from NTuple" begin