Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors are gone in logging on master #53384

Closed
KristofferC opened this issue Feb 19, 2024 · 6 comments
Closed

Colors are gone in logging on master #53384

KristofferC opened this issue Feb 19, 2024 · 6 comments
Labels
logging The logging framework
Milestone
1.11

Comments

@KristofferC
Copy link
Member

KristofferC commented Feb 19, 2024 •
edited
Loading

image
@KristofferC KristofferC added the logging The logging framework label Feb 19, 2024
@KristofferC KristofferC added this to the 1.11 milestone Feb 19, 2024
@KristofferC
Copy link
Member Author

@tecosaur, is this some styled string thing? But Logging depends on that and there are still no colors?

@tecosaur
Copy link
Contributor

tecosaur commented Feb 19, 2024 •
edited
Loading

Should be fixed with #53333 (the problem was introduced when the original PR was reverted due to what now seems to be an unrelated compiler issue).

@giordano
Copy link
Contributor

Logging macros without using Logging are still colourless:

image

@giordano giordano reopened this Feb 25, 2024
@KristofferC
Copy link
Member Author

Yew, but that is captured in a different issue already.

@giordano
Copy link
Contributor

Link to the issue for reference?

@fredrikekre
Copy link
Member

#52075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
logging The logging framework
Projects
None yet
Milestone
1.11
Development

No branches or pull requests
4 participants
@giordano @KristofferC @fredrikekre @tecosaur