-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance regression in "spellcheck" string processing benchmark #50458
Labels
domain:strings
"Strings!"
kind:regression
Regression in behavior compared to a previous version
performance
Must go faster
Milestone
Comments
KristofferC
added
performance
Must go faster
kind:regression
Regression in behavior compared to a previous version
domain:strings
"Strings!"
labels
Jul 7, 2023
I'm pretty sure #49249 is the same as this? |
Is this fixed by #50444? |
Also no ;) |
reduced to
On 1.9: |
fixed by #50929 (once that gets backported) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain:strings
"Strings!"
kind:regression
Regression in behavior compared to a previous version
performance
Must go faster
The benchmark at https://github.com/JuliaCI/BaseBenchmarks.jl/blob/master/src/problem/SpellCheck.jl has a ~4x regression vs 1.9. A repro that can be copy pasted is
This gives
Quickly looking at a profile, this looks suspicious:
In 1.9, there seems to be way less time spent in that part:
The text was updated successfully, but these errors were encountered: