Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in gf.c jl_type_infer: why not define in_reference as atomic #47712

Closed
awfeequdng opened this issue Nov 26, 2022 · 1 comment
Closed

in gf.c jl_type_infer: why not define in_reference as atomic #47712

awfeequdng opened this issue Nov 26, 2022 · 1 comment

Comments

@awfeequdng
Copy link
Contributor

in master branch, file gf.c, function jl_type_infer: why not define in_reference as atomic
image

@fingolfin
Copy link
Contributor

The code in there was only run if a lock was held, so no need for atomics.

But it also was replaced by different code in PR #46825.

So I think this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants