Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heap Snapshot #46862

Merged
merged 25 commits into from
Oct 5, 2022
Merged

Heap Snapshot #46862

merged 25 commits into from
Oct 5, 2022

Conversation

apaz-cli
Copy link
Member

This picks up from the work done on #42286.

apaz-cli and others added 2 commits September 22, 2022 11:23
@apaz-cli @whatsthecraic
@NHDaly @vilterp @vchuravy
Added heap profiler.
01b6af2 
Co-Authored-By: Dean De Leo <dean.deleo@relational.ai>
Co-Authored-By: Nathan Daly <NHDaly@gmail.com>
Co-Authored-By: Pete Vilter <7341+vilterp@users.noreply.github.com>
Co-Authored-By: Valentin Churavy <v.churavy@gmail.com>
Co-Authored-By: @whatsthecraic
@apaz-cli @vtjnash
Updated/Rewrote heap snapshot PR. Moved to Profile package, optimized…
03addad 
…, and added all_one flag.

Co-Authored-By: Jameson Nash <vtjnash@gmail.com>
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc.c Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc.c Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc.c Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc.c Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Sep 22, 2022
View reviewed changes
src/gc.c Outdated Show resolved Hide resolved
@vchuravy vchuravy mentioned this pull request Sep 23, 2022
Closed
29 tasks
apaz-cli and others added 14 commits September 23, 2022 10:09
@apaz-cli @vtjnash
remove newline
72206ea 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@apaz-cli @vtjnash
Update src/gc-heap-snapshot.cpp
8acc854 
This is the only occurrence of a brace on the following line.

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@apaz-cli @vtjnash
Removed unnecessary cast
042bc5b 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@apaz-cli @vtjnash
Remove extra todo
f300a21 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@apaz-cli @vtjnash
Update src/gc.c
3b5a832 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@apaz-cli
Added cleanup to test.
19fbec8
@apaz-cli
Added back cast, removed check for jl_buff_tag.
325ca8b
@apaz-cli
Added docs about all_one.
a814039
@apaz-cli
Added take_heap_snapshot() to Profile docs.
59ce09b
@apaz-cli
TODOs only for gc_heap_snapshot_record
5a40b9e
@apaz-cli
Changed stack frame size to 0 so synthetic root node doesn't show up …
868c0ff 
…in Chrome devtools.
@apaz-cli @vtjnash
Remove gc_heap_snapshot_record_module_to_binding
0354572 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@apaz-cli
Fully removed record module edge.
dc8df96
@apaz-cli
Using jl_atomic_load_relaxed() to load atomic fields from binding.
89cf29e
vtjnash
vtjnash reviewed Sep 28, 2022
View reviewed changes
src/gc-heap-snapshot.cpp Outdated Show resolved Hide resolved
@IanButterworth
Copy link
Member

I just wanted to say that I tried this out after running some extensive code and it saved the snapshot with no issue and it loaded in devtools. Thanks for pushing this forward!

Also, a NEWS entry would be good I think

vtjnash
vtjnash reviewed Oct 3, 2022
View reviewed changes
src/gc.c Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Oct 3, 2022
View reviewed changes
src/gc-heap-snapshot.h Outdated Show resolved Hide resolved
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Oct 5, 2022
@NHDaly
Copy link
Member

NHDaly commented Oct 5, 2022

INCREDIBLE!
Thanks so much @apaz-cli for picking this up! We over at RAI were just dancing, celebrating this work. We are super excited! 😭
Many thanks, @apaz-cli, @vtjnash, @vchuravy!
- Love, @vilterp and me ❤️

@vtjnash vtjnash merged commit 956e0a3 into JuliaLang:master Oct 5, 2022
@vtjnash vtjnash added needs news A NEWS entry is required for this change and removed merge me PR is reviewed. Merge when all tests are passing labels Oct 5, 2022
@antoine-levitt antoine-levitt added this to the 1.12 milestone Oct 24, 2022
@PallHaraldsson
Copy link
Contributor

PallHaraldsson commented Oct 26, 2022 •
edited
Loading

@antoine-levitt what's the point of adding "to the 1.12 milestone"? It was already merged, so in 1.9-DEV already! I assume 1.12 was in error (since far away), you meant to add a different version number and/or change elsewhere?

@vtjnash vtjnash removed this from the 1.12 milestone Oct 26, 2022
@antoine-levitt
Copy link
Contributor

I think my pocket did that, sorry!

@JeffBezanson JeffBezanson removed the needs news A NEWS entry is required for this change label Nov 10, 2022
@nickrobinson251 nickrobinson251 mentioned this pull request Dec 8, 2022
Merged
@maleadt maleadt mentioned this pull request Jun 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@apaz-cli @IanButterworth @NHDaly @PallHaraldsson @antoine-levitt @vtjnash @JeffBezanson