-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disk stat functions #42248
Add disk stat functions #42248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, lgtm other than the requests in my comments! :) Thanks for the PR
Should I also export the |
An alternative interface could be to have a single function, e.g. |
(Requested re-review from Fredrik regarding the interface changes, i.e. addition of |
Sorry it took me so long to get back to this, PTAL! |
Not sure what the remaining test failures are about, any help would be much appreciated! |
From a brief look at some of the failure logs and associated buildbot histories, at least some of the failures appear likely to be unrelated (noting strings of failures on corresponding buildbots having started before the most recent builds associated with this pull request). |
To confirm, there appear to be ongoing CI issues; hopefully those will be resolved in the not too distant future, then this pull request can be rebased, and we can have another look :). |
I am not certain whether the unrelated failures that show up in some of these logs have been resolved, but folks have been working on them and most recent builds appear to be passing. Perhaps rebase / clean up the history a bit and push to get another snapshot? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few fixes and suggestions for you. Looks pretty good so far. The CI failures look mostly familiar from some issues last week.
Sorry again for the slow progress on this PR — I've removed StatFS and instead specialized
won't print out the "virtual" fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a line to the NEWS.md file and another line to the doc/src/base/file.md file? The rest LGTM!
Thanks again for all the reviews, much appreciated! Added your feedback and updated the docs + NEWS. |
Thanks so much for sticking with this PR. I've put the merge-me tag on, so that we either merge it soon, or there is one last chance for anyone to comment. |
++ not bad for a first contribution! :) Thanks for the PR! |
This PR exposes the
uv_fs_statfs()
libuv 1.31 function to obtain available, used, and total disk.It closes #37038.