Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests in my package is failing with Julia-nightly #42087

Closed
ronisbr opened this issue Sep 2, 2021 · 9 comments
Closed

Some tests in my package is failing with Julia-nightly #42087

ronisbr opened this issue Sep 2, 2021 · 9 comments

Comments

@ronisbr
Copy link
Sponsor Member

ronisbr commented Sep 2, 2021

Hi!

I am not sure if this is expected, but a set of tests in SatelliteToolbox.jl started to fail in Julia-nightly.

The test line is:

            Ba = @test_logs (:warn, "The magnetic field computed with this IGRF version may be of reduced accuracy for years greater than 2025.") #=
                 =# igrf(date, r*1000, (90-colat)*pi/180, elong*pi/180)

which is returning this:

   Test.LogRecord(Warn, "`@_inline_meta` is deprecated, use `@inline` instead.", Core.Compiler, :depwarn, (Ptr{Nothing} @0x00007fc3dfed00e3, Symbol("@_inline_meta")), "./compiler/utilities.jl", 111, Base.Pairs{Symbol, Any, Tuple{Symbol, Symbol}, NamedTuple{(:caller, :maxlog), Tuple{Base.StackTraces.StackFrame, Int64}}}(:caller => get_staged(mi::Core.MethodInstance) at utilities.jl:111, :maxlog => 1))

Is it expected?

@oscardssmith
Copy link
Member

To clarify, does SatelliteToolbox call @_inline_meta directly ever?

@Seelengrab
Copy link
Contributor

Doesn't look like it:

:SatelliteToolbox.jl $ rg "@_inline_meta" | wc -l
0                                                          
:SatelliteToolbox.jl $ rg "@inline" | wc -l 
135                                                        

@ronisbr
Copy link
Sponsor Member Author

ronisbr commented Sep 2, 2021

To clarify, does SatelliteToolbox call @_inline_meta directly ever?

No, I do not use!

@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 2, 2021

The backtrace above shows it is from an @generated function

@KristofferC
Copy link
Sponsor Member

@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 2, 2021

Can we make this a silent deprecation? It is hard to support both otherwise

@timholy
Copy link
Sponsor Member

timholy commented Sep 4, 2021

What about a Compat.@inline? (Edit: oh, actually in this case it's so simple that we can just extend the macro in Compat without needing the module qualifier.) And then we should ping all the package maintainers in that search. (It's not really so many.)

This prompted the addition of an "Add to Compat.jl" label, see #41312 (comment)

@moble
Copy link
Contributor

moble commented Feb 19, 2022

@ronisbr This seems to be resolved for me. Can this issue be closed?

@ronisbr
Copy link
Sponsor Member Author

ronisbr commented Mar 20, 2022

Sorry for the late response, I totally missed the notification. Yes, thank you very much! The issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants