-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify and improve printing of qualified names #39841
base: master
Are you sure you want to change the base?
Conversation
Ah, so Documenter uses a temporary module with an invalid identifier name plus some regex magic, which is causing the weird
|
af0f425
to
ae005e1
Compare
ae005e1
to
9d3850d
Compare
9d3850d
to
29b5b8b
Compare
This removes repeated code, fixes some cases where quoting was not done correcly (e.g. `Mod.:+`), and checks identifier visibility recursively so only a minimal module path is printed. fixes #39834
29b5b8b
to
090c4c9
Compare
Of course this ended up being much more involved than you'd think. The main issue seems to be whether to do this for print/string as well as show/repr. So far I kept the output of
since interpolation uses
If print and show are different, that can be confusing of course. But if they're the same, we hit #29466 in that the result of |
Triage says: this is maybe justifiable if we combine it with something else that makes it easier to write these kinds of tests. Maybe combining it with #29466 would do that, by making |
This removes repeated code, fixes some cases where quoting was not done
correcly (e.g.
Mod.:+
), and checks identifier visibility recursivelyso only a minimal module path is printed.
fixes #39834