Add support to multiple property pairs in sprint #39381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
the
domain:display and printing
|
Bump! |
|
I think this should have a compat note in the docstring, but otherwise looks good to me. |
|
@simeonschaub Done! I think I just need to add the information to NEWS.md, but I will wait for approval to avoid multiple rebases. |
|
Bump! |
Sometimes it is required to pass multiple properties to `IOContext` in `sprint`. For example, if we want to print with `:compact` and `:limit` set to true. Currently, the only possible way to do this is creating an `IOContext` using a dummy `IOBuffer` with those parameters. Hence, this commit allows to pass a vector of pairs `:key=>value` to `context` keyword of `sprint` so that we can easily set multiple properties. This is not a breaking change, and no performance regression was identified when using the previous function signatures.
Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com>
|
Done @rfourquet ! Thanks for the review. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Add support to multiple property pairs in sprint Sometimes it is required to pass multiple properties to `IOContext` in `sprint`. For example, if we want to print with `:compact` and `:limit` set to true. Currently, the only possible way to do this is creating an `IOContext` using a dummy `IOBuffer` with those parameters. Hence, this commit allows to pass a vector of pairs `:key=>value` to `context` keyword of `sprint` so that we can easily set multiple properties. This is not a breaking change, and no performance regression was identified when using the previous function signatures. * Add compat annotation to sprint * Update base/strings/io.jl Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> * Update sprint docstring * Update NEWS.md * Move NEWS.md entry to the correct place Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Add support to multiple property pairs in sprint Sometimes it is required to pass multiple properties to `IOContext` in `sprint`. For example, if we want to print with `:compact` and `:limit` set to true. Currently, the only possible way to do this is creating an `IOContext` using a dummy `IOBuffer` with those parameters. Hence, this commit allows to pass a vector of pairs `:key=>value` to `context` keyword of `sprint` so that we can easily set multiple properties. This is not a breaking change, and no performance regression was identified when using the previous function signatures. * Add compat annotation to sprint * Update base/strings/io.jl Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com> * Update sprint docstring * Update NEWS.md * Move NEWS.md entry to the correct place Co-authored-by: Rafael Fourquet <fourquet.rafael@gmail.com>
|
Hi there. A pity that namedtuple support has not been implemented in addition. # done
sprint(show, v; context=(:compact=>true, :limit=>true))
# still todo
sprint(show, v; context=(; compact=true, limit=true)) # more julian IMHOI'am a bit short on time those days to pr it EDITED if context isa NamedTuple
f(IOContext(s, pairs(context)...), args...)should be enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is required to pass multiple properties to
IOContextinsprint. For example, if we want to print with:compactand:limitset to true. Currently, the only possible way to do this is creating an
IOContextusing a dummyIOBufferwith those parameters. Hence, thiscommit allows to pass a vector of pairs
:key=>valuetocontextkeyword of
sprintso that we can easily set multiple properties.This is not a breaking change, and no performance regression was
identified when using the previous function signatures.