Implement a hook in base for disabling threading #30004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/threading_hook
branch
from
d092f92
to
edffb57
Compare
|
Ah, this is basically #25951 (comment) |
|
Bump for Julia 1.1 |
vtjnash
reviewed
Dec 6, 2018
|
Triage is in favor if you want to get this passing CI and merge it. Wants a NEWS entry too, right? |
StefanKarpinski
removed
the
status:triage
JeffBezanson
approved these changes
Dec 6, 2018
StefanKarpinski
added
the
domain:multithreading
fredrikekre
force-pushed
the
fe/threading_hook
branch
from
edffb57
to
1609b85
Compare
of libraries, use it to decouple Distributed from LinearAlgebra.
fredrikekre
force-pushed
the
fe/threading_hook
branch
from
1609b85
to
7b48911
Compare
fredrikekre
changed the title
|
Great, updated. The last CI runs was during some flaky times IIRC, so I don't think there was something wrong with the PR. |
|
This seems to be causing the Distributed tests to fail on PkgEval: |
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
of libraries, use it to decouple Distributed from LinearAlgebra.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a hook in base for disabling threading of libraries, use it to decouple
DistributedfromLinearAlgebra.Alternative to #29975, WIP because I don't know if this is the interface we want, where the code should live, and what the names of the functions should be. Maybe not very important since these are all internal functions.