Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Regex a scalar in broadcasting #29913

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Make Regex a scalar in broadcasting #29913

merged 2 commits into from
Nov 7, 2018

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Nov 2, 2018 •
edited
Loading

@fredrikekre fredrikekre requested a review from mbauman November 2, 2018 23:39
@StefanKarpinski
Copy link
Member

Diff best seen ignoring whitespace; related: don't squash since there's a testset-introducing commit.

@mbauman
Copy link
Member

mbauman commented Nov 2, 2018

Ref #29250 (would close it if it weren't already closed).

@fredrikekre
Copy link
Member Author

Had to move the definition from regex.jl to broadcast.jl for bootstrapping reasons.

@KristofferC KristofferC added the needs news A NEWS entry is required for this change label Nov 3, 2018
@fredrikekre fredrikekre added broadcast Applying a function over a collection and removed needs news A NEWS entry is required for this change labels Nov 5, 2018
@fredrikekre fredrikekre merged commit 1be7fa5 into master Nov 7, 2018
@fredrikekre fredrikekre deleted the fe/regex branch November 7, 2018 20:17
@KristofferC KristofferC added the needs news A NEWS entry is required for this change label Nov 7, 2018
@mbauman mbauman removed the needs news A NEWS entry is required for this change label Nov 7, 2018
@mbauman
Copy link
Member

mbauman commented Nov 7, 2018

@KristofferC https://github.com/JuliaLang/julia/pull/29913/files#diff-8312ad0561ef661716b48d09478362f3R17

@KristofferC
Copy link
Member

Missed that, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
broadcast Applying a function over a collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredrikekre @StefanKarpinski @mbauman @KristofferC