Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recent benchmark regressions #27539

Closed
JeffBezanson opened this issue Jun 11, 2018 · 5 comments
Closed

recent benchmark regressions #27539

JeffBezanson opened this issue Jun 11, 2018 · 5 comments
Labels
kind:regression Regression in behavior compared to a previous version performance Must go faster

Comments

@JeffBezanson
Copy link
Sponsor Member

Identified in 2ba3fbb#commitcomment-29323024
@JeffBezanson JeffBezanson added performance Must go faster kind:regression Regression in behavior compared to a previous version labels Jun 11, 2018
@fredrikekre
Copy link
Member

Quoting Jamesons comment from the link:

Looks like the test for atan2 needs to be updated (now deprecated to atan) and the following were broken sometime since it last ran (vs = daily_2018_5_23):

  • sumlinear_view
  • collection iteration (Dict, Set, Vector)
  • lufact Tridiagonal factorization
  • problems: go_game, parse_json, grigoriadis_khachiyan, laplacian, spellcheck, stockcorr, ziggurat
  • simd: conditional_loop, loop_fields!, manual_example!, sum_reduce, two_reductions
  • string join

79486b3...2ba3fbb [173 commits]

lufact is most likely due to the deprecation too.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jul 6, 2018

I think I've fixed string join. Do we know if any of the others have been addressed? When we run a benchmark comparison against v0.6, it would be helpful to add that link here also.

@KristofferC
Copy link
Sponsor Member

KristofferC commented Jul 6, 2018 •
edited
Loading

#27030

Has updated benchmark runs. String join was mostly fixed by #27685

vtjnash referenced this issue Jul 6, 2018
@Keno
Add a test for #9765
ae8e95f 
Fixes #9765 (the correctness fix was part of the fix for #27910)
@KristofferC
Copy link
Sponsor Member

sumlinear_view regression dissappear when @simd is removed.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jul 7, 2018

OK. The rest seem to be fixed too now, I'll merge this into #27685

@vtjnash vtjnash closed this as completed Jul 7, 2018
@vtjnash vtjnash mentioned this issue Jul 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:regression Regression in behavior compared to a previous version performance Must go faster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vtjnash @JeffBezanson @KristofferC @fredrikekre