Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewOptimizer] (Legacy) IR does not show line number information anymore #27149

Closed
maleadt opened this issue May 18, 2018 · 3 comments · Fixed by #29893
Closed

[NewOptimizer] (Legacy) IR does not show line number information anymore #27149

maleadt opened this issue May 18, 2018 · 3 comments · Fixed by #29893
Assignees
Labels
regression Regression in behavior compared to a previous version

Comments

@maleadt
Copy link
Member

maleadt commented May 18, 2018

   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.4839 (2018-04-10 06:39 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 000f243d5d* (38 days old master)
|__/                   |  x86_64-pc-linux-gnu

julia> @code_warntype sin(1)
Variables:
  x::Int64

Body:
  begin
      # meta: location float.jl float 266
      # meta: location float.jl Type 251
      # meta: location float.jl Type 57
      Core.SSAValue(4) = (Base.sitofp)(Float64, x::Int64)::Float64
      # meta: pop locations (3)
      Core.SSAValue(1) = $(Expr(:invoke, MethodInstance for sin(::Float64), :(Base.Math.sin), Core.SSAValue(4)))::Float64
      return Core.SSAValue(1)
  end::Float64
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.5127 (2018-05-18 07:05 UTC)
 _/ |\__'_|_|_|\__'_|  |  master/ecf24255ac* (fork: 4086 commits, 303 days)
|__/                   |  x86_64-pc-linux-gnu

julia> @code_warntype sin(1)
Variables:
  x::Int64

Body:
  begin
      (Base.sitofp)(Float64, x::Int64)::Float64
      $(Expr(:invoke, MethodInstance for sin(::Float64), :(Base.Math.sin), Core.SSAValue(1)))::Float64
      return Core.SSAValue(2)
  end::Float64
@maleadt maleadt added the regression Regression in behavior compared to a previous version label May 18, 2018
@Keno
Copy link
Member

Keno commented May 18, 2018

There's new printing for the new IR, which needs to be hooked up.

@mbauman
Copy link
Member

mbauman commented May 18, 2018

Even more annoying is that we're missing the printing of SSAValue assignments. I think we're just seeing the RHS.

@vtjnash
Copy link
Member

vtjnash commented Sep 13, 2018

This was closed, but the referenced PR didn't actually bring back most of the information we used to have access to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants