Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitrand seems to be much slower on 0.7 #26505

Closed
dpsanders opened this issue Mar 18, 2018 · 2 comments
Closed

bitrand seems to be much slower on 0.7 #26505

dpsanders opened this issue Mar 18, 2018 · 2 comments
Labels
performance Must go faster randomness Random number generation and the Random stdlib regression Regression in behavior compared to a previous version

Comments

@dpsanders
Copy link
Contributor

dpsanders commented Mar 18, 2018

I'm seeing a bad slowdown (150x) for bitrand from 0.6->0.7:

0.6:

julia> using BenchmarkTools; 

julia> @btime rand(Bool, 10^6);
  1.936 ms (2 allocations: 976.70 KiB)

julia> @btime bitrand(10^6);
  18.010 μs (7 allocations: 122.42 KiB)

0.7:

julia> using Random, BenchmarkTools;

julia> @btime rand(Bool, 10^6);
@btime bitrand(10^6);
  1.746 ms (2 allocations: 976.70 KiB)

julia> @btime bitrand(10^6);
  2.797 ms (3 allocations: 122.23 KiB)
@nalimilan nalimilan added performance Must go faster regression Regression in behavior compared to a previous version labels Mar 18, 2018
@StefanKarpinski
Copy link
Member

StefanKarpinski commented Mar 18, 2018

It's deprecated, perhaps that's why? EDIT: derp, you're using the version in Random, nevermind.

@ararslan ararslan added the randomness Random number generation and the Random stdlib label Mar 19, 2018
@KristofferC
Copy link
Member

KristofferC commented Mar 20, 2018

(Will be) Fixed by #26529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster randomness Random number generation and the Random stdlib regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

5 participants