Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate isreal(::AbstractArray)? #26401

Closed
JeffBezanson opened this issue Mar 9, 2018 · 6 comments
Closed

deprecate isreal(::AbstractArray)? #26401

JeffBezanson opened this issue Mar 9, 2018 · 6 comments
Labels
arrays [a, r, r, a, y, s] broadcast Applying a function over a collection deprecation This change introduces or involves a deprecation

Comments

@JeffBezanson
Copy link
Member

In 0.6 we deprecated isinteger(a::AbstractArray) to all(isinteger, a). However we still have such a method for isreal.

If any and all had inbounds annotations, then we would be able to optimize these to constants.
@JeffBezanson JeffBezanson added arrays [a, r, r, a, y, s] deprecation This change introduces or involves a deprecation broadcast Applying a function over a collection labels Mar 9, 2018
@ararslan
Copy link
Member

ararslan commented Mar 9, 2018

I believe that was discussed somewhere and IIRC @stevengj was against that change for mathematical reasons.

@ararslan
Copy link
Member

ararslan commented Mar 9, 2018

Ah #19996

@JeffBezanson
Copy link
Member Author

Oh, ok. Then perhaps this release is converging after all :)

@stevengj
Copy link
Member

Yes, I still feel the same way.

@nalimilan
Copy link
Member

Don't the same linear algebra considerations apply to both isreal and isinteger? I.e. shouldn't we deprecate both or none of them?

@stevengj
Copy link
Member

stevengj commented Mar 10, 2018 •
edited
Loading

@nalimilan, no. You wouldn't say that [1,2,3] "is an integer". You would say that it "is real". There is a well defined, standard, sense in which operations like real and conj apply to vectors as a whole, and not just to their contents.

@singularitti singularitti mentioned this issue Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s] broadcast Applying a function over a collection deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JeffBezanson @nalimilan @stevengj @ararslan