Deprecate findn(x) in favor of find(!iszero, x), which now returns cartesian indices #25532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2018
ararslan
added
the
kind:deprecation
The BitArray method was missed when changing the AbstractArray method to return CartesianIndices for multidimensional arrays. Also fix the find(x) docstring which was inconsistent with the find(f, x) one.
JeffBezanson
approved these changes
Jan 14, 2018
base/deprecated.jl
Outdated
| @@ -2772,6 +2772,8 @@ end | |||
|
|
|||
| @deprecate findin(a, b) find(occursin(b), a) | |||
|
|
|||
| @deprecate findn(x::AbstractArray) (I = find(!iszero, x); (getindex.(I, 1), getindex.(I, 2))) | |||
There was a problem hiding this comment.
Is it worth trying to support non-2d arrays?
There was a problem hiding this comment.
Good catch. I've added a method for vectors and another for general arrays, and restricted this one to matrices.
…rtesian indices Also make find(::Function, ::SparseMatrixCSC) slightly more efficient by avoiding an intermediate allocation of index vectors.
DilumAluthge
added a commit
that referenced
this pull request
Oct 14, 2023
Note: In #25532, `findn(x::AbstractArray)` was deprecated in favor of `findall(!iszero, x)`. However, the word `findn` will still appear in various places, such as `HISTORY.md`, so we should probably ignore it from `codespell`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #24910. Part of #10593. Performance seems roughly equivalent (but I couldn't use
@benchmarksince BenchmarkTools currently doesn't load on master).The first commit fixes for things that have been missed by #24774.