Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl test errors on windows #24730

Closed
staticfloat opened this issue Nov 23, 2017 · 3 comments
Closed

repl test errors on windows #24730

staticfloat opened this issue Nov 23, 2017 · 3 comments
Labels
REPL Julia's REPL (Read Eval Print Loop) system:windows Affects only Windows test This change adds or pertains to unit tests

Comments

@staticfloat
Copy link
Member

win32 and win64 buildbots are running into repl test errors, although I have been unable to reproduce the errors outside of the buildbot environment. The error is:

Error in testset repl:
Test Failed at C:\cygwin\home\Administrator\buildbot\slave\package_win32\build\test\repl.jl:161
  Expression: contains(s, "shell> ")

Which I traced back to this commit by @vtjnash. Again, when running Julia directly in bash on the windows buildbot this works just fine, but when run inside of the buildbot, it seems to be having trouble.

@vtjnash
Copy link
Member

vtjnash commented Nov 23, 2017

I think that test may be assuming —color=true gets selected.

@ararslan ararslan added REPL Julia's REPL (Read Eval Print Loop) test This change adds or pertains to unit tests system:windows Affects only Windows labels Nov 23, 2017
@staticfloat
Copy link
Member Author

Yes, I think you're right. Although I'm not entirely sure why this would be happening, as setting --color=no doesn't actually remove the color from the prompt, unless we actually have three code paths here, (--color=yes, --color=no, and something else that actually does disable color in the prompt) ;)

@KristofferC
Copy link
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REPL Julia's REPL (Read Eval Print Loop) system:windows Affects only Windows test This change adds or pertains to unit tests
Projects
None yet
Development

No branches or pull requests

4 participants