From f6e0600c45a6cd6493f00bfed696bda070d9e365 Mon Sep 17 00:00:00 2001
From: Jeff Bezanson <jeff.bezanson@gmail.com>
Date: Mon, 27 Jun 2022 13:06:20 -0400
Subject: [PATCH] fix obvious_subtype bug with egal objects (#45771)

When egal objects contain identical typevars with different
environments, the resulting subtyping might not be so obvious.

Fix #45703

(cherry picked from commit 8ccf2d6b1fb0acc2c8e9766d320c34cb8445cae9)
---
 src/subtype.c   | 11 +++++++++--
 test/subtype.jl |  9 +++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/subtype.c b/src/subtype.c
index c43d307e6d4213..aea5b80a5cadf6 100644
--- a/src/subtype.c
+++ b/src/subtype.c
@@ -1542,8 +1542,15 @@ static int obvious_subtype(jl_value_t *x, jl_value_t *y, jl_value_t *y0, int *su
         *subtype = 1;
         return 1;
     }
-    if (jl_is_unionall(x))
-        x = jl_unwrap_unionall(x);
+    while (jl_is_unionall(x)) {
+        if (!jl_is_unionall(y)) {
+            if (obvious_subtype(jl_unwrap_unionall(x), y, y0, subtype) && !*subtype)
+                return 1;
+            return 0;
+        }
+        x = ((jl_unionall_t*)x)->body;
+        y = ((jl_unionall_t*)y)->body;
+    }
     if (jl_is_unionall(y))
         y = jl_unwrap_unionall(y);
     if (x == (jl_value_t*)jl_typeofbottom_type->super)
diff --git a/test/subtype.jl b/test/subtype.jl
index a0a6c96c300d74..b17f502bc2e006 100644
--- a/test/subtype.jl
+++ b/test/subtype.jl
@@ -1987,3 +1987,12 @@ let A = Tuple{typeof(identity), Type{Union{}}},
     B = Tuple{typeof(identity), typeof(Union{})}
     @test A == B && (Base.isdispatchtuple(A) == Base.isdispatchtuple(B))
 end
+
+# issue #45703
+# requires assertions enabled (to catch discrepancy in obvious_subtype)
+let T = TypeVar(:T, Real),
+    V = TypeVar(:V, AbstractVector{T}),
+    S = Type{Pair{T, V}}
+    @test !(UnionAll(T, UnionAll(V, UnionAll(T, Type{Pair{T, V}}))) <: UnionAll(T, UnionAll(V, Type{Pair{T, V}})))
+    @test !(UnionAll(T, UnionAll(V, UnionAll(T, S))) <: UnionAll(T, UnionAll(V, S)))
+end