From da2d8d7440ded008331791f199df348807c7359b Mon Sep 17 00:00:00 2001 From: Daniel Karrasch Date: Thu, 5 Nov 2020 19:22:06 +0100 Subject: [PATCH] remove obsolete code --- stdlib/LinearAlgebra/src/triangular.jl | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/stdlib/LinearAlgebra/src/triangular.jl b/stdlib/LinearAlgebra/src/triangular.jl index f541421bb6563e..21e387a16fd6eb 100644 --- a/stdlib/LinearAlgebra/src/triangular.jl +++ b/stdlib/LinearAlgebra/src/triangular.jl @@ -694,28 +694,11 @@ mul!(C::AbstractMatrix, A::AbstractTriangular, adjB::Adjoint{<:Any,<:AbstractVec mul!(C::AbstractVecOrMat, A::AbstractTriangular, adjB::Adjoint{<:Any,<:AbstractVecOrMat}) = (B = adjB.parent; lmul!(A, adjoint!(C, B))) -# The three methods for each op are neceesary to avoid ambiguities with definitions in matmul.jl +# The three methods are neceesary to avoid ambiguities with definitions in matmul.jl mul!(C::AbstractVector , A::AbstractTriangular, B::AbstractVector) = lmul!(A, copyto!(C, B)) mul!(C::AbstractMatrix , A::AbstractTriangular, B::AbstractVecOrMat) = lmul!(A, copyto!(C, B)) mul!(C::AbstractVecOrMat, A::AbstractTriangular, B::AbstractVecOrMat) = lmul!(A, copyto!(C, B)) -# function mul!(C::AbstractVector, adjA::Adjoint{<:Any,<:AbstractTriangular}, B::AbstractVector) -# return lmul!(adjA, copyto!(C, B)) -# end -# function mul!(C::AbstractMatrix, adjA::Adjoint{<:Any,<:AbstractTriangular}, B::AbstractVecOrMat) -# return lmul!(adjA, copyto!(C, B)) -# end -# function mul!(C::AbstractVecOrMat, adjA::Adjoint{<:Any,<:AbstractTriangular}, B::AbstractVecOrMat) -# return lmul!(adjA, copyto!(C, B)) -# end -# function mul!(C::AbstractVector, transA::Transpose{<:Any,<:AbstractTriangular}, B::AbstractVector) -# return lmul!(transA, copyto!(C, B)) -# end -# function mul!(C::AbstractMatrix, transA::Transpose{<:Any,<:AbstractTriangular}, B::AbstractVecOrMat) -# return lmul!(transA, copyto!(C, B)) -# end -# function mul!(C::AbstractVecOrMat, transA::Transpose{<:Any,<:AbstractTriangular}, B::AbstractVecOrMat) -# return lmul!(transA, copyto!(C, B)) -# end + @inline mul!(C::AbstractMatrix, A::AbstractTriangular, B::Adjoint{<:Any,<:AbstractVecOrMat}, alpha::Number, beta::Number) = mul!(C, A, copy(B), alpha, beta) @inline mul!(C::AbstractMatrix, A::AbstractTriangular, B::Transpose{<:Any,<:AbstractVecOrMat}, alpha::Number, beta::Number) = @@ -1742,7 +1725,7 @@ end powm(A::LowerTriangular, p::Real) = copy(transpose(powm!(copy(transpose(A)), p::Real))) # Complex matrix logarithm for the upper triangular factor, see: -# Al-Mohy and Higham, "Improved inverse scaling and squaring algorithms for +# Al-Mohy and Higham, "Improved inverse scaling and squaring algorithms for # the matrix logarithm", SIAM J. Sci. Comput., 34(4), (2012), pp. C153–C169. # Al-Mohy, Higham and Relton, "Computing the Frechet derivative of the matrix # logarithm and estimating the condition number", SIAM J. Sci. Comput.,