From d0ce71a52c9771e3d73090a9ae007d9f4f0a8366 Mon Sep 17 00:00:00 2001
From: Andreas Noack <andreasnoackjensen@gmail.com>
Date: Wed, 24 Jan 2018 10:07:19 +0100
Subject: [PATCH] Define scaling of triagular matrix from the right and the
 left

---
 stdlib/LinearAlgebra/src/triangular.jl | 69 +++++++++++++++++++++++---
 1 file changed, 61 insertions(+), 8 deletions(-)

diff --git a/stdlib/LinearAlgebra/src/triangular.jl b/stdlib/LinearAlgebra/src/triangular.jl
index 15e6e8c01332b..550b0a01bf2c8 100644
--- a/stdlib/LinearAlgebra/src/triangular.jl
+++ b/stdlib/LinearAlgebra/src/triangular.jl
@@ -400,32 +400,85 @@ function copyto!(A::T, B::T) where T<:Union{LowerTriangular,UnitLowerTriangular}
     return A
 end
 
-function mul!(A::UpperTriangular, B::Union{UpperTriangular,UnitUpperTriangular}, c::Number)
+function mul!(A::UpperTriangular, B::UpperTriangular, c::Number)
     n = checksquare(B)
     for j = 1:n
-        if isa(B, UnitUpperTriangular)
-            @inbounds A[j,j] = c
+        for i = 1:j
+            @inbounds A[i,j] = B[i,j] * c
         end
-        for i = 1:(isa(B, UnitUpperTriangular) ? j-1 : j)
+    end
+    return A
+end
+function mul!(A::UpperTriangular, c::Number, B::UpperTriangular)
+    n = checksquare(B)
+    for j = 1:n
+        for i = 1:j
             @inbounds A[i,j] = c * B[i,j]
         end
     end
     return A
 end
-function mul!(A::LowerTriangular, B::Union{LowerTriangular,UnitLowerTriangular}, c::Number)
+function mul!(A::UpperTriangular, B::UnitUpperTriangular, c::Number)
+    n = checksquare(B)
+    for j = 1:n
+        @inbounds A[j,j] = c
+        for i = 1:(j - 1)
+            @inbounds A[i,j] = B[i,j] * c
+        end
+    end
+    return A
+end
+function mul!(A::UpperTriangular, c::Number, B::UnitUpperTriangular)
+    n = checksquare(B)
+    for j = 1:n
+        @inbounds A[j,j] = c
+        for i = 1:(j - 1)
+            @inbounds A[i,j] = c * B[i,j]
+        end
+    end
+    return A
+end
+function mul!(A::LowerTriangular, B::LowerTriangular, c::Number)
+    n = checksquare(B)
+    for j = 1:n
+        for i = j:n
+            @inbounds A[i,j] = B[i,j] * c
+        end
+    end
+    return A
+end
+function mul!(A::LowerTriangular, c::Number, B::LowerTriangular)
+    n = checksquare(B)
+    for j = 1:n
+        for i = j:n
+            @inbounds A[i,j] = c * B[i,j]
+        end
+    end
+    return A
+end
+function mul!(A::LowerTriangular, B::UnitLowerTriangular, c::Number)
     n = checksquare(B)
     for j = 1:n
-        if isa(B, UnitLowerTriangular)
             @inbounds A[j,j] = c
+        for i = (j + 1):n
+            @inbounds A[i,j] = B[i,j] * c
         end
-        for i = (isa(B, UnitLowerTriangular) ? j+1 : j):n
+    end
+    return A
+end
+function mul!(A::LowerTriangular, c::Number, B::UnitLowerTriangular)
+    n = checksquare(B)
+    for j = 1:n
+            @inbounds A[j,j] = c
+        for i = (j + 1):n
             @inbounds A[i,j] = c * B[i,j]
         end
     end
     return A
 end
+
 mul1!(A::Union{UpperTriangular,LowerTriangular}, c::Number) = mul!(A, A, c)
-mul2!(c::Number, A::Union{UpperTriangular,LowerTriangular}) = mul1!(A', c')'
+mul2!(c::Number, A::Union{UpperTriangular,LowerTriangular}) = mul!(A, c, A)
 
 fillstored!(A::LowerTriangular, x)     = (fillband!(A.data, x, 1-size(A,1), 0); A)
 fillstored!(A::UnitLowerTriangular, x) = (fillband!(A.data, x, 1-size(A,1), -1); A)