-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show package version and whether it's the latest after ] add
command
#2682
Comments
There's a lot of support for this, and an issue already #1655 but perhaps part of this issue is just raising the prominence of which package was installed in the output? Perhaps that's unique, so worth keeping this issue open for? |
I feel it's distinct as that one is written for |
I think it is ok if this is not shown in the output for |
I don't think that this is enough. New users want to know whether the docs they check are matching the version they installed. They can double check that with your PR but they can't just assume it. I don't assume that the PR will reduce the number of issues created on packages where something didn't fit the documentation simply because an older version was installed unknowingly. |
I really think So often I assume it installed the latest version only to realize later that it ended up installing an old version because of some random conflict. |
If you have requirements for what version you need, the way to most easily handle that is to add that to the
to the Project file. |
Done in #2906 |
Currently the output of
add OrdinaryDiffEq
looks roughly like:and then shows the important info:
for a few milliseconds
and creating tenth of lines about which versions of packages are added to the Manifest file.
at the very end it shows:
I think the most important information the user wants is missing here:
The second question is important when one has multiple packages in the environment and they aren't compatible with each other. Currently this can result in installing an ancient version of a package without notifying the user. That user will probably checked the latest version of the docs though and is frustrated that something doesn't work and either moves away from the package or creates an issue where they still might not realize that it is an old version.
I suggest therefore to end the
] add command
with something like:Package v0.5 was added as the newest version v0.7 isn't compatible
or
The latest version of Package (v0.7) was successfully installed
Maybe the upper one in orange and the lower one in green.
I'm happy to work on a PR for this. If you have any pointers of where I should start I would be very grateful.
The text was updated successfully, but these errors were encountered: