fix: rename and cleanup convert functions #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianna
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 71.21% 71.10% -0.11%
==========================================
Files 4 4
Lines 1619 1613 -6
==========================================
- Hits 1153 1147 -6
Misses 466 466 ☔ View full report in Codecov by Sentry. |
|
Do you know how to change the 1.8 required in CI? |
Moelf
approved these changes
Nov 28, 2023
No, I was trying to find it, but haven't done it yet :-( |
|
I somehow think it's bugged, I think it was set by @jpivarski when it was a personal repo, and the setting was transferred to this org repo, except the JuliaHEP org doesn't have paid plan to support this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.