Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to PythonCall.jl and refactor testing #48

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Nov 28, 2023

  • move PyCall.jl -> PythonCall.jl
  • remove manual installing Python related stuff in CI, now these test-only dependencies are managed in Project.toml
  • use the Pkg.jl extension system (available in 1.9+) to optionally load functions in ext/AwkwardPythonCall/ when user load PythonCall.jl
  • in test, we set environment variable JULIA_CONDAPKG_BACKEND="Null" to use the same Python environment we installed manually on CI, we should document this for users
  • sorry about large diff, because I moved files around to make "stub" visible from the main AwkwardArray.jl source file

SubArray{Float64,1,Vector{Float64},Tuple{UnitRange{Int64}},true},
:default,
},
:default,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there must be a better way to check layout other than hard coding all these types, these type parameters shouldn't be considered fully stable

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f125f1) 71.32% compared to head (9c08674) 71.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   71.32%   71.21%   -0.11%     
==========================================
  Files           3        4       +1     
  Lines        1618     1619       +1     
==========================================
- Hits         1154     1153       -1     
- Misses        464      466       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf Moelf requested a review from ianna November 28, 2023 13:30
Copy link
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Moelf ! BTW, why the 15 line difference if it's just a move? I used a JuliaFormatter is that the reason? Thanks!

@ianna ianna changed the title move to PythonCall.jl and refactor testing feat: move to PythonCall.jl and refactor testing Nov 28, 2023
@Moelf
Copy link
Member Author

Moelf commented Nov 28, 2023

No I moved but also need to remove top and bottom lines for the module definition.

Because module definition is now in the AwkwardArray.jl main source file

@ianna ianna self-requested a review November 28, 2023 14:25
Copy link
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's merge it if you are done with it. I see what's not covered by the tests. We can add them in the next PR.

@Moelf Moelf merged commit 41db204 into main Nov 28, 2023
4 of 5 checks passed
@Moelf Moelf deleted the refactor_testing branch November 28, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants