-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move to PythonCall.jl and refactor testing #48
Conversation
SubArray{Float64,1,Vector{Float64},Tuple{UnitRange{Int64}},true}, | ||
:default, | ||
}, | ||
:default, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there must be a better way to check layout other than hard coding all these types, these type parameters shouldn't be considered fully stable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 71.32% 71.21% -0.11%
==========================================
Files 3 4 +1
Lines 1618 1619 +1
==========================================
- Hits 1154 1153 -1
- Misses 464 466 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Moelf ! BTW, why the 15 line difference if it's just a move? I used a JuliaFormatter is that the reason? Thanks!
No I moved but also need to remove top and bottom lines for the module definition. Because module definition is now in the AwkwardArray.jl main source file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Let's merge it if you are done with it. I see what's not covered by the tests. We can add them in the next PR.
Project.toml
ext/AwkwardPythonCall/
when user loadPythonCall.jl
JULIA_CONDAPKG_BACKEND="Null"
to use the same Python environment we installed manually on CI, we should document this for usersAwkwardArray.jl
source file