Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename and cleanup convert functions #47

Closed
wants to merge 19 commits into from

Conversation

ianna
Copy link
Member

@ianna ianna commented Nov 28, 2023

No description provided.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f125f1) 71.32% compared to head (9e3489c) 71.21%.

❗ Current head 9e3489c differs from pull request most recent head 9453842. Consider uploading reports for the commit 9453842 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   71.32%   71.21%   -0.11%     
==========================================
  Files           3        3              
  Lines        1618     1612       -6     
==========================================
- Hits         1154     1148       -6     
  Misses        464      464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianna ianna force-pushed the ianna/rename-and-cleanup-convert-functions branch from 9e3489c to 9453842 Compare November 28, 2023 14:07
@ianna ianna requested a review from Moelf November 28, 2023 14:38
@Moelf
Copy link
Member

Moelf commented Nov 28, 2023

sorry I introduced conflict to this PR

@ianna
Copy link
Member Author

ianna commented Nov 28, 2023

sorry I introduced conflict to this PR

no problem, I'll rebase it :-)

@ianna
Copy link
Member Author

ianna commented Nov 28, 2023

moved to #49

@ianna ianna closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants