Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move AwkwardPythonCallExt to a proper package extention #111

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Oct 10, 2024

@ianna

this moves the AwkwardPythonCallExt to be a proper ext.

I simply did the most straightforward way so please let me know if I missed anything.

@Moelf Moelf changed the title move PythonCallExt to proper ext move AwkwardPythonCallExt to a proper package extention Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.09%. Comparing base (ba9ef0e) to head (e192c5b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   76.94%   76.09%   -0.86%     
==========================================
  Files           5        5              
  Lines        1800     1740      -60     
==========================================
- Hits         1385     1324      -61     
- Misses        415      416       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Project.toml Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
Copy link
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Moelf - Thanks! I'll write more tests to cover the code. Please, go ahead and merge it asis if you have finished with pr. Thanks.

@Moelf Moelf merged commit 6ba1c4a into main Oct 10, 2024
7 of 8 checks passed
@Moelf Moelf deleted the proper_Pkg_Ext branch October 10, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants