Adds Permeability #225
Merged
Adds Permeability #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by: Jacob Frasunkiewicz <jfrasunk@hotmail.com>
Co-authored by: Jacob Frasunkiewicz <jfrasunk@hotmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
|
|
||
| function compute_permeability!(k::AbstractArray, s::ConstantPermeability; kwargs...) | ||
| @unpack_val k_val = s | ||
| k[:] .= k_val |
There was a problem hiding this comment.
Suggested change
| k[:] .= k_val | |
| k .= k_val |
Not sure why you want to convert it into a vector.
There was a problem hiding this comment.
this has also been done here. This can be removed in both cases I guess
src/Viscosity/BulkViscosity.jl
Outdated
| end | ||
|
|
||
|
|
||
| ### Georg Adjoint 2 pahse paper, |
There was a problem hiding this comment.
Suggested change
| ### Georg Adjoint 2 pahse paper, | |
| ### Georg Adjoint 2 phase paper, |
src/Viscosity/BulkViscosity.jl
Outdated
| """ | ||
| function bulk_viscosity(η_shear, ϕ, C, R, λ, P_eff) | ||
|
|
||
| η_bulk = η_shear / ϕ * C * (1.0 + 0.5 * (inv(R) - 1.0) * (1.0 + tanh(-P_eff * inv(λ)))) |
There was a problem hiding this comment.
Suggested change
| η_bulk = η_shear / ϕ * C * (1.0 + 0.5 * (inv(R) - 1.0) * (1.0 + tanh(-P_eff * inv(λ)))) | |
| η_bulk = η_shear / ϕ * C * (1 + 0.5 * (inv(R) - 1) * (1 + tanh(-P_eff * inv(λ)))) |
There was a problem hiding this comment.
This file slipped into the PR, should be removed or adapted to GP syntax
albert-de-montserrat
requested changes
Oct 17, 2024
Co-authored-by: Albert de Montserrat <58044444+albert-de-montserrat@users.noreply.github.com>
albert-de-montserrat
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a first part of permeability to GP:
ConstantPermeabilityHazenPermeabilityPowerLawPermeabilityCarmanKozenyPermeability