Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name and integration with WorldBankData.jl #1

Open
ajkeith opened this issue Feb 11, 2019 · 2 comments
Open

Package name and integration with WorldBankData.jl #1

ajkeith opened this issue Feb 11, 2019 · 2 comments

Comments

@ajkeith
Copy link

ajkeith commented Feb 11, 2019

This is a great idea for a package, but I wonder if the name could be more specific to de-conflict with country data for other domains (e.g., geographic information for mapping). Maybe something like FinanceCountries.jl or ISOCountries.jl.

Alternatively, it might make sense to expand the scope to make this the default package for all kinds of data about countries, which would be pretty cool. Mostly the region and developed fields seem like they already overlap with WorldBankData.jl.

In the spirit of preferring many small packages to one big package, maybe the best architecture would be to keep this as a limited, finance specific package with a specific name, and then have a Countries.jl meta-package that loads all the domain-specific country libraries (finance, economic, geographic, etc)?

@EricForgy
Copy link
Member

Hi @ajkeith 👋

Thanks for your comment 😊

Just before seeing your comment, I actually submitted a PR to METADATA to register Countries.jl 😊

If you have some concerns, please feel free to voice them over there as well

JuliaLang/METADATA.jl#21493

I actually have high hopes for Julia's package management system to be able to handle things like this. Very soon, the package name will not matter so much and everything will be based off a UUID.

In fact, my dream is for Julia's general registry to allow the registration of registries :)

For example, JuliaFinance can have it's own registry for our package. Users can either add our registry directly to their path OR a big thing on my wishlist is for JuliaFinance to be able to register our registry on the general registry and the general registry plays the role of a DNS or something and people can do something like:

pkg> add @JuliaFinance/Countries.jl

where the @JuliaFinance redirects to our registry :)

I understand where you are coming from, but I am not a fan of long names like FinanceCountries or ISOCountries or anything other than Countries for that matter 😅🙏

I designed this package to be easily extendable so my hope would be, as you hinted, this one could be the default package and other packages extend this one.

I also put out a request for feedback here JuliaFinance/Roadmap#5

Would love to hear your thoughts 😊

@EricForgy
Copy link
Member

Hi again 👋

Good morning. Just getting started here in Manila ☕️😊

I thought about this a little more and I realize your comment overlaps a bit with some of our discussions about currencies. See JuliaFinance/Roadmap#4.

Everything in the new Currencies.jl is static data about the currency:

  • Name
  • Code
  • Minor Units

These are not expected to change (at least not frequently). However, Currencies.jl intentionally does not include FX rates. The argument for not including FX rates in a simple Currencies.jl package was that Currencies.jl should be minimal and we should have some kind of market data quote provider that lives independently. After all, FX rates fluctuate in real time and are influenced by supply and demand etc. For this, we need something like a MarketData.jl.

I think a similar case can be made for Countries.jl. Currently, Countries.jl contains

  • Name
  • Code
  • Capital
  • Continent
  • Developing
  • Region
  • Subregion
  • Currencies

Like Currencies.jl, these are not expected to change (at least not frequently). However, there is data about these countries that does change frequently. Therefore, there should be an external provider of data that lives independently of Countries.jl. For this, I think it could be something like WorldBankData.jl.

Speaking of which, it would be nice to welcome WorldBankData.jl into JuliaFinance as I think financial inclusion and financial development are certainly in scope 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants