Added power variogram fit function #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @stepanoslejsek ! Can you please add a test to cover the new feature? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 72.39% 73.66% +1.26%
==========================================
Files 36 36
Lines 913 957 +44
==========================================
+ Hits 661 705 +44
Misses 252 252 ☔ View full report in Codecov by Sentry. |
|
For sure! I'll add few tests. |
juliohm
requested changes
Oct 22, 2024
juliohm
reviewed
Oct 22, 2024
|
Oh, I'm sorry for that typo there, I'll edit these immediately. |
juliohm
approved these changes
Oct 22, 2024
|
Thank you @stepanoslejsek for the contribution! I will wait the CI tests, merge and adjust a few more things internally before a patch release. |
juliohm
reviewed
Oct 22, 2024
juliohm
reviewed
Oct 22, 2024
juliohm
approved these changes
Oct 23, 2024
|
Thank you @stepanoslejsek , really nice work 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of power variogram fit function as discussed at https://discourse.julialang.org/t/recommended-workflow-and-packages-for-computing-a-slope-along-a-tramway-track/119975/16 using weighted least squares.