Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justification of Table Columns #511

Closed
ccoffrin opened this issue Jun 4, 2017 · 6 comments
Closed

Justification of Table Columns #511

ccoffrin opened this issue Jun 4, 2017 · 6 comments
Milestone

Comments

@ccoffrin
Copy link

ccoffrin commented Jun 4, 2017

It seems like the right-side justification on tables is not working. For example see, https://lanl-ansi.github.io/PowerModels.jl/latest/results.html

Also I noticed that the bold directive does not seem to work on this page. Both in the body of the text and in the table header.

The bold directive is recognized by github's markdown renderer, https://github.com/lanl-ansi/PowerModels.jl/blob/8d6ffb0dad80be64255d28d16afbff0c9c9e3c94/docs/src/results.md

@mortenpi
Copy link
Member

mortenpi commented Jun 4, 2017

Hmm, it appears the HTML writer does not honour alignment at all. It actually came as a surprise to me that cells should be right-aligned by default according to Base docs. Generally most Markdown table implementations seem to left-align. But in any case, Documenter should simply follow Base here.

Bold looks fine to me though.
just

@ccoffrin
Copy link
Author

ccoffrin commented Jun 4, 2017

I also tried ---: to force right alignment, but it did not seem to help. As for the bold thing, this is what I am seeing on Chrome Version 58.0.3029.110 (64-bit) on OS X 10.11.6

screen shot 2017-06-04 at 5 35 38 pm

@mortenpi
Copy link
Member

mortenpi commented Jun 4, 2017

I also tried ---: to force right alignment, but it did not seem to help.

Yup, those get ignored in HTMLWriter as well.

As for bold: that is interesting. I would guess it is somehow specific to your system though. Would still be good to know what is going on -- could you maybe go in with Chrome devtools and see why the appropriate CSS is not being applied? Do you see the same thing in Safari?

@ccoffrin
Copy link
Author

ccoffrin commented Jun 5, 2017

Works in Safari 10.1.1 (11603.2.5) on the same computer. I took a quick glance via chrome inspect, but the CSS is out of my depth and it was not immediately clear to me what was going on.

@juliohm
Copy link
Contributor

juliohm commented Sep 2, 2017

Is it possible to fix this column alignment or is it something beyond Documenter.jl?

@s-celles
Copy link

s-celles commented Aug 23, 2018

Center alignment doesn't work also:

| object | implemented |  value |
| :---   |    :---:    |   ---: |
| `A`    |      ✓      |  10.00 |
| `BB`   |      ✓      | 100.00 |

is rendered as (in Github)

object implemented value
A 10.00
BB 100.00

but in Documenter.jl it's rendered like:
deepin capture-ecran_zone de selection _20180823102557

mortenpi added a commit that referenced this issue Mar 24, 2019
Note that tables that do not explicitly define alignment default to be
right-aligned.

Fix #511
mortenpi added a commit that referenced this issue Mar 25, 2019
* Enable table column alignment in HTML

Note that tables that do not explicitly define alignment default to be
right-aligned.

Fix #511
@mortenpi mortenpi added this to the 0.22.0 milestone Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants