Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing Git in git_remote_head_branch #1871

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Handle missing Git in git_remote_head_branch #1871

merged 2 commits into from
Jul 13, 2022

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Jul 12, 2022

This is currently against release-0.27 since I wrote this on top of the 0.27.20 tag, and needs to be brought up to date with with master.

Fix #1870.

@mortenpi mortenpi added this to the 0.27.21 milestone Jul 12, 2022
@mortenpi
Copy link
Member Author

@glennmoy Any chance you could run this branch in your Git-less Docker container, to see if it fixes the problem and to make sure that there are no more oversights.

@glennmoy
Copy link

@glennmoy Any chance you could run this branch in your Git-less Docker container, to see if it fixes the problem and to make sure that there are no more oversights.

yes that works! thank you!

julia> doctest(MyPackage)
┌ Warning: Unable to determine HTML(edit_link = ...) from remote HEAD branch, defaulting to "master".
│ Unable to find the `git` binary. Unless this is due to a configuration error, the
│ relevant variable should be set explicitly.
└ @ Documenter.Utilities ~/.julia/packages/Documenter/scBHi/src/Utilities/Utilities.jl:797
[ Info: SetupBuildDirectory: setting up build directory.
[ Info: Doctest: running doctests.
[ Info: Skipped ExpandTemplates step (doctest only).
[ Info: Skipped CrossReferences step (doctest only).
[ Info: Skipped CheckDocument step (doctest only).
[ Info: Skipped Populate step (doctest only).
[ Info: Skipped RenderDocument step (doctest only).
Test Summary:     | Pass  Total
Doctests: MyPackage |    1      1
Test.DefaultTestSet("Doctests: MyPackage", Any[], 1, false, false)

@mortenpi mortenpi changed the base branch from release-0.27 to master July 12, 2022 22:13
@mortenpi mortenpi mentioned this pull request Jul 13, 2022
@mortenpi mortenpi merged commit 91e2eff into master Jul 13, 2022
@mortenpi mortenpi deleted the mp/fix-1870 branch July 13, 2022 06:24
mortenpi added a commit that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doctest() fails when git is not installed
2 participants