Fix LaTeX logs with Docker, merge docs/make.jl scripts #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
added
Type: Maintenance
Type: Documentation
Format: LaTeX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with writing the
LaTeXWriter.{stderr,stdout}logs when using Docker:The consecutive
piperuncalls erase the earlier logs, and so we only end up with the logs fordocker cp. So this PR makes sure we callpipelinewithappendenabled (when appropriate).However, copying over the
build/directory with the output from the Docker container also creates some sort of a race condition, wiping out the log files. To avoid that, we now only copy the PDF file out of the container, rather than copying everything. The other output files are probably not important anyway, and this also makes the generated CI artifacts smaller.To test this, this also uploads the PDF logs as an artifact for Documenter docs. Not sure how much we'll need it here, but this is more of a test case for the main Julia manual. An example upload (for a failed build) can be found here: https://github.com/JuliaDocs/Documenter.jl/actions/runs/2225386676
In addition, I am merging the
docs/make.jlanddocs/pdf/make.jl, since there is quite a bit of duplication there. The PDF can be built withjulia docs/make.jl pdfnow. @fredrikekre: I think you create this as a separate make script --- any opinions either way here?Once this is tagged and used for the Julia nightly, we can fix JuliaLang/julia#45077 (with some preliminary work here and here).