-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add index.html
generation for redirecting to ./stable
or ./dev
#1657
Conversation
Thanks @hyrodium, this is great! I am concerned that this will overwrite user-created files -- there might be some cases where the user wants to maintain their own However, the URL might change (e.g.
I am kinda partial two (2), even if it's a little more complicated, since that still allows the user to also manually maintain an |
Thanks for the review! |
This was what I was thinking too, and looks like you implemented that now in the PR so 👍 |
I've fixed the redirected destination, and I think this is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you add an entry to the NEWS.md file?
I've updated the CHANGELOG.md. (btw, not NEWS.md:smile:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
LGTM, thanks. I'll let @mortenpi look over it and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @hyrodium and @fredrikekre!
This PR solves #937.