Add support for Azure DevOps URL scheme #1463
Conversation
|
@mortenpi is there any reason to use font awesome over inline SVG icons? From what I can see (though I'm sure there are more) the only icons used are settings cog, hamburger (can be replaced with ☰ anyway), branded repo logos and file logo for unknown repo - it seems a bit heavy to include FontAwesome and FontAwesomeBrands just for these Happy to do a separate PR to move to inline SVGs if you think this is a good idea? Edit: maybe more general icons than is worth the effort, perhaps worthwhile just for the brand icons though... |
|
LGTM, will merge shortly. Thanks a lot @friggog! Regarding the use of SVG icons: I'd say FA is just the simplest option that gives a set of consistently styles icons. No objections to using an SVG icon if, for example, FA doesn't have an icon available. It doesn't look like FA actually adds that much to the page load time though, so I am not sure it's worth complicating things with our own icons. We'd have to deploy the small icons on every build ourselves then. And there's also the IP side of things: where would you "source" the icons from? |
|
FontAwesome has the SVGs directly available and free to use as far as I can tell. Also simple-icons. I'll open a separate PR with some changes in and you can see what you think. |
Resolves #1462