-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the deploy_folder
fallbacks and the docstring for deploy_folder
#1315
Conversation
@mortenpi @fredrikekre I think this should fix the |
I tried to add a docstring for This is the docstring I tried to add: """
DeployDecision(; kwargs...)
Struct containing information about the decision to deploy or not deploy.
# Arguments
- `all_ok::Bool` - Should documentation be deployed?
- `branch::String` - The branch to which documentation should be pushed
- `is_preview::Bool` - Is this documentation build a pull request?
- `repo::String` - The repo to which documentation should be pushed
- `subfolder::String` - The subfolder to which documentation should be pushed
""" |
I re-added the docstring, let's see what happens. I don't see anything in it that should cause linkcheck to fail. However, Travis and AppVeyor tests were both failing too, without the docstring. |
All right I think I should've fixed the tests now. |
Okay, CI is passing now. |
@mortenpi @fredrikekre Anything else I should add to this PR? |
No description provided.