-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsed view menu button should be on the same side as the menu #1312
Comments
Yep, it comes from here. I'll leave this open for now if there are others who'd like to chime in, but personally I am inclined to leave it unchanged. That button is aimed for mobile users, in which case it's not really that disconnected from the menu: I prefer having it there, since then I can just use my thumb to tap it, without either having to reach over the screen or using the other hand. Looking around on some websites, it's also quite common to have the menu button on the right, so it should be a familiar UX for the users. |
I can understand that motivation. Do you have an example of a right-side menu button where the menu doesn't open adjacent to the button? Because it wasn't familiar to this user. The menu is on the left side, so that's where I looked for a way to activate it. It's also going into a collapsed view when the window is occupying a bit less than half of my 3840x2160 (150% dpi) display. So if it's a mobile feature, perhaps it's activating at too wide a view. Traversing that distance with the mouse every time is annoying. If unchanged, it would at least be really helpful if there was some nub at the left edge to activate. |
It' s strange to serve the mobile users. For me I like tiling windows half of screen on 1080p screens. It just triggers the collapse which makes it very far from reach. I don' t find that button a familiar UX because it was near the github button to edit the doc, I thought it was something related to editing pages at first thus dare not try when I didn' t find it at left. |
I hit this issue more than once last week. I also use left/right split screen on laptop. I know the table of contents is on the left and it always takes me a while to figure out how to access it. |
I concede that having the hamburger on the left is more common, also e.g. in the Android ecosystem. The Guardian does have it on the right. I also see examples where it is positioned on the right, but the menu opens from the top, so it's not quite the same. In any case, I do think now that it would be an improvement to have it on the left. So if someone wants to fiddle with the (S)CSS and provide a functioning mockup, I'd be happy to make the change.
Separate from the hamburger issue, we should probably adjust when exactly the sidebar collapses, to better serve this use case (related: #1324). |
Is it enough to just move the hamburger button to the left? I think we need to fix this before we can add the new TOC sidebar (#1688).
Documenter.jl/src/html/HTMLWriter.jl Lines 1221 to 1225 in 579d478
|
I don't know if this is standard, but I saw it used in docs.juliaplots.org so reporting it here, presuming this package generated it.
Menu appears on the left but the menu button is on the top right. This just doesn't work well. Please keep them on the same side.
The text was updated successfully, but these errors were encountered: