Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit the number for the first link fragment on a page #1292

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Omit the number for the first link fragment on a page #1292

merged 1 commit into from
Apr 16, 2020

Conversation

fredrikekre
Copy link
Member

Omit the number for the first link fragment on a page;
before: #foobar-1, #foobar-2
after: #foobar, #foobar-2

@fredrikekre fredrikekre force-pushed the fe/fragments branch 2 times, most recently from 1fcb0ca to e6b1326 Compare April 14, 2020 11:16
@mortenpi mortenpi added this to the 0.25.0 milestone Apr 16, 2020
mortenpi
mortenpi approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the merge.

You're right that the else path there probably never gets used at the moment. But you can imagine, in principle, some plugin adding its own anchors to the document, so I think there's no harm in handling that edge case.

CHANGELOG.md Outdated Show resolved Hide resolved
@mortenpi mortenpi changed the title Omit the number for the first link fragment on a page; Omit the number for the first link fragment on a page Apr 16, 2020
@fredrikekre
Omit the number for the first link fragment on a page;
cc56dec 
Before: #foobar-1, #foobar-2,
After: #foobar, #foobar-2.

For legacy reasons the old fragments are also insert in
order to not break old links spread throughout the internet.
@fredrikekre fredrikekre merged commit 540c17a into master Apr 16, 2020
@fredrikekre fredrikekre deleted the fe/fragments branch April 16, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @mortenpi