-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support push preview docs. #1180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
fredrikekre
force-pushed
the
fe/preview
branch
from
November 16, 2019 00:08
d769226
to
fb872c0
Compare
fredrikekre
force-pushed
the
fe/preview
branch
from
November 16, 2019 00:23
fb872c0
to
f9c69cc
Compare
Resulting page: https://fredrikekre.github.io/Literate.jl/previews/PR80/ |
fredrikekre
force-pushed
the
fe/preview
branch
from
November 16, 2019 01:38
2943696
to
044564c
Compare
Documenter can now push preview docs from PRs (when the head branch is from the same repository). This is enabled by passing push_preview=true to deploydocs. Documenter will then push rendered documentation to preview/PR## where ## is the pull request number.
fredrikekre
force-pushed
the
fe/preview
branch
from
November 16, 2019 01:39
044564c
to
1bf8cd5
Compare
mortenpi
approved these changes
Nov 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks @fredrikekre!
@@ -747,8 +747,7 @@ function doctest( | |||
) | |||
true | |||
catch err | |||
@error "Doctesting failed" | |||
showerror(stdout, err, catch_backtrace()) | |||
@error "Doctesting failed" exception=(err, catch_backtrace()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know that this works 👍
asinghvi17
added a commit
to JuliaDynamics/DrWatson.jl
that referenced
this pull request
Feb 9, 2020
Datseris
pushed a commit
to JuliaDynamics/DrWatson.jl
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenter can now push preview docs from PRs (when the head branch is from the same repository). This is enabled by passing
push_preview=true
todeploydocs
. Documenter will then push rendered documentation topreviews/PR##
where##
is the pull request number.