Handle invalid syntax in doctests #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the terminal, parse errors do not have a backtrace. But we still need to initialize the result.bt field.
The heuristic in error_to_string which removes the backtrace below the highest Core.eval call works in most cases, but will fail if makedocs/doctest gets called in a more complicated context, as there may sometimes be eval calls higher up in the stacktrace.
On the nightly, syntax errors now get stacktraces, which means that their output is no longer deterministic. Hence we can't really compare against the fixed output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, if you have invalid syntax in a doctest (e.g.
julia> 1.2.3), it can be doctested against the correct parse error output. Fix #487.