Fix strict=true not failing for doctest failures #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was introduced in #958, where the push!, which was hidden away in the DocTests.report function, got accidentally removed. It is not clear from its name that the report function should have a side-effect like this, so it is cleaner if the push! calls are next to the report calls, even if it creates slight code duplication. Fix #1003
omus
added a commit
to JuliaTime/TimeZones.jl
that referenced
this pull request
May 16, 2019
Was an issue with Documenter which was fixed in version 0.22.4: JuliaDocs/Documenter.jl#1014
omus
added a commit
to JuliaTime/TimeZones.jl
that referenced
this pull request
May 17, 2019
Was an issue with Documenter which was fixed in version 0.22.4: JuliaDocs/Documenter.jl#1014
kpamnany
pushed a commit
to RelationalAI-oss/TimeZones.jl
that referenced
this pull request
May 5, 2023
Was an issue with Documenter which was fixed in version 0.22.4: JuliaDocs/Documenter.jl#1014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was introduced in #958, where the
push!, which was hidden away in theDocTests.reportfunction, got accidentally removed. It is not clear from its name that thereportfunction should have a side-effect like this, so it is cleaner if thepush!calls are next to the report calls, even if it creates slight code duplication.Fix #1003