Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackoverflow with QR #114

Closed
Kolaru opened this issue Nov 16, 2020 · 0 comments · Fixed by #128
Closed

Stackoverflow with QR #114

Kolaru opened this issue Nov 16, 2020 · 0 comments · Fixed by #128

Comments

@Kolaru
Copy link
Contributor

Kolaru commented Nov 16, 2020

Using j′vp on a QR factorization result in a stackoverflow, like in the following example:

using FiniteDifferences
using LinearAlgebra

X = randn(5, 5)
j′vp(central_fdm(5, 1), X->qr(X).Q, randn(5, 5), X)

I believe it is due to the fact that vec(Q) return a Base.ReshapedArray (for Q, R = qr(X)).

Causes problem while testing JuliaDiff/ChainRules.jl#306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant