-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rrule for QR-decomposition #651
Comments
CC @cscherrer |
We already have #516, #306, and #469. 2 of these are by the author of the linked blog post. QR rules in Julia are trickier than in PyTorch, jax, etc for reasons summarized in #469 (comment). I'll allocate some time in the coming month to dig into these proposals and push this forward. |
Oh, right - thanks @sethaxen ! I'll close this issue, then. |
Sorry, I somehow overlooked the existing PRs. |
@GiggleLiu anything you can help with here ? |
I probably can help with testing complex valued backward rule, and thin qr. The general purposed qr backward with pivot is a bit tricky. Since I do not have time to dive into all of these issues at the moment, I would suggest copy-paste the part that you need? |
Would be nice to have an
rrule
for QR-decomposition.According to https://rkube.github.io/jekyll/update/2021/07/06/backpropagating-through-qr.html, Pytorch uses the method described in https://arxiv.org/abs/1710.08717 .
The text was updated successfully, but these errors were encountered: