Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrule for QR-decomposition #651

Closed
oschulz opened this issue Jul 21, 2022 · 6 comments
Closed

rrule for QR-decomposition #651

oschulz opened this issue Jul 21, 2022 · 6 comments

Comments

@oschulz
Copy link

oschulz commented Jul 21, 2022

Would be nice to have an rrule for QR-decomposition.

According to https://rkube.github.io/jekyll/update/2021/07/06/backpropagating-through-qr.html, Pytorch uses the method described in https://arxiv.org/abs/1710.08717 .

@oschulz
Copy link
Author

oschulz commented Jul 21, 2022

CC @cscherrer

@sethaxen
Copy link
Member

We already have #516, #306, and #469. 2 of these are by the author of the linked blog post.

QR rules in Julia are trickier than in PyTorch, jax, etc for reasons summarized in #469 (comment). I'll allocate some time in the coming month to dig into these proposals and push this forward.

@oschulz
Copy link
Author

oschulz commented Jul 21, 2022

Oh, right - thanks @sethaxen ! I'll close this issue, then.

@oschulz oschulz closed this as completed Jul 21, 2022
@oschulz
Copy link
Author

oschulz commented Jul 21, 2022

Sorry, I somehow overlooked the existing PRs.

@wangleiphy
Copy link

@GiggleLiu anything you can help with here ?

@GiggleLiu
Copy link

@GiggleLiu anything you can help with here ?

I probably can help with testing complex valued backward rule, and thin qr. The general purposed qr backward with pivot is a bit tricky. Since I do not have time to dive into all of these issues at the moment, I would suggest copy-paste the part that you need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants