do_typeinf!(interp, mi) does not always put mi into cache

[simeonschaub]

On nightly, the following returns false:

julia> using Cthulhu

julia> mi = Core.Compiler.specialize_method(Base._methods(seekstart, (IOBuffer,), -1, Base.get_world_counter())[])
MethodInstance for seekstart(::IOBuffer)

julia> interp = Cthulhu.CthulhuInterpreter()
Cthulhu.CthulhuInterpreter(Core.Compiler.NativeInterpreter(...), IdDict{Union{Core.Compiler.InferenceResult, Core.MethodInstance}, Cthulhu.InferredSource}(), IdDict{Core.MethodInstance, Core.CodeInstance}(), IdDict{Union{Core.Compiler.InferenceResult, Core.MethodInstance}, Vector{Pair{Int64, String}}}(), IdDict{Union{Core.Compiler.InferenceResult, Core.MethodInstance}, Dict{Int64, Core.Compiler.Effects}}(), IdDict{Union{Core.Compiler.InferenceResult, Core.MethodInstance}, Dict{Int64, Any}}())

julia> Cthulhu.do_typeinf!(interp, mi)

julia> mi in keys(interp.opt)
false

whereas on 1.11:

julia> mi in keys(interp.opt)
true

This causes e.g. @descend annotate_source=false seekstart(IOBuffer()) to error. Perhaps this is a regression in base?

[simeonschaub]

I bisected this to JuliaLang/julia#54816

@vtjnash Is this a bug in that PR or is this working as intended and we just need to make adjustments on our side?