Fix empty unstack on empty data frame #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nalimilan - here only coverage fails (and it is false positive) |
nalimilan
approved these changes
Aug 24, 2021
| dfu = unstack(df, :b, :c) | ||
| @test isempty(dfu) | ||
| @test names(dfu) == ["a"] | ||
| @test dfu.a isa Vector{Any} |
There was a problem hiding this comment.
Any particular reason to check this type?
There was a problem hiding this comment.
For current and future safety I guess. I was surprised that:
julia> Symbol.(Any[])
Any[]
because I knew that:
julia> map(Symbol, Any[])
Symbol[]
so I thought it does not hurt to be extra careful with empty collections and add a test.
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2841