Merge meanings of cols keyword arguments between push! and vcat

[rapus95]

:intersect does mean different things currently

[bkamins]

Agreed this should be fixed. What alternative name for what :intersect in push! does do you think is good. I think that in vcat it is an appropriate name. In push! we should not change the behavior, so we should change the name of this option.

Thank you!

[rapus95]

As :subset means that the new row needs to be at most a subset of columns. How about :superset?
Might add that to vcat aswell.

[bkamins]

Yes - :superset is a good name for this!

[bkamins]

Given #1958 is merged is this still on 1.0 roadmap (I think not so I have removed the tag). The additional functionalities discussed here are non-breaking.

[rapus95]

I'll add it in the overhaul I wanted to make. As #1958 is now merged, I guess I can start working on it, can't I?

[bkamins]

Yes, but I removed 1.0 milestone, as I understand your changes will be non-breaking (they will only clean up internal code or add functionality) - right?

[rapus95]

Yes, but I removed 1.0 milestone, as I understand your changes will be non-breaking (they will only clean up internal code or add functionality) - right?

Indeed, if every keyword meaning is cleaned up and consistent now and we have enough test coverage that pass, then my change will not introduce any changes to the API besides adding some new keywords. If we will add any new arguments to an API function then we'll add them by keywords, thus, that should be compatible aswell, I guess.

[bkamins]

Closed in favor of #2032