-
Notifications
You must be signed in to change notification settings - Fork 89
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
named transfer functions #885
Comments
I have considered implementing a new StateSpace type that includes a lot of the functionality that is currently scattered across multiple different statespace types, such as
Unfortunately, moving the implementation of a function from ROC to CS cannot be done in a non-breaking way if we want to export the function from CS. I'm also hesitant bringing all that code into ControlSystems, the NamedStateSpace type is still quite immature with lots of problems in how it interacts with other system types and functions not handling it properly etc. I'm thus not yet ready to bring it here and signal that it's ready and stabe. RobustAndOptimalControl is still at version 0.x, which accurately signals that it's not quite as mature as ContorlSystems is. What exactly is the problem with As for named transfer functions, implementing such a type would be a ton of effort, the incomplete implementation of |
I understand. No particular application in mind except for having the plots automatically add the label. I also liked the ease with which one can build complicated connections used |
Yeah, the reason there is simply that I don't want to put experimental and immature features in a package that aims at being stable and mature :) Control engineers are often risk averse (for good reasons, we don't want planes falling out of the sky), so trying hard to signal stability and maturity is especially important for CS.jl. |
I should mention that there is nothing preventing you from implementing a package NamedTransferFuncitons.jl, as long as you extend the appropriate functions
The bodeplot will work as you want |
Ah, and the other reason was that RobustAndOptimalControl requires anyway ControlSystems. That said, you are the best person with an overview of the packages development. As for you other comment: one should also extend |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Would you consider having named transfer functions and perhaps even moving named_ss from
RobustAndOptimalControl.jl
toControlSystems.jl
?I am asking because the
bodeplot
gives generic names to the outputs and because for LTISystems, the default name is emptyThe text was updated successfully, but these errors were encountered: